Grant me the serenity to accept the things I cannot change, courage to change the things I can, and wisdom to know the difference.
Notes
- Milestone option group, problem related to mapping.
- Configure keys gives popup to add for existing event.
- Event ID and fixture ID are almost same, you can find event ID from URL and same is used in fixture-view API.
- v2 events are created in TOSCA.
- Player milestone market is created by TOSCA and not from BCM.
- TV2_API our headshot code will not work
- scoreboard.scss line 174
- figma without dev mode see by using ctrl + alt.
- TV2_API we are not sure how we will integrate for headshot in the CDS
- Shurya squad is facing data related issues.
- headshotmilestone_option_group parentLeagueId is coming as ID.
- Pritam is showing on dev that participants[] and showing for first two teams and same team are present in SA but for player we are not able to find the source: v2 entries in participants[] array and same is not showing in SA.
4450 review
- Dynacon
- One strong point is validation.
- Custom logics like getHeadershotImage , in init we can change the image if else block, widget API which gets the top events data.
- Reason being TV2 and TV1 are similar for fixture-view API.
- Rumyana is not speaking much and listening well, got convinced on showing the code and validation, so it was basically miscommunication.
- rumyana will be taking the moving logics in component to common place with Stefan and will get back, meanwhile we will keep a US and changes for this ready after we are done with current activity.
- Fallback image is also connected with rootPath in some way.
- Test case failing,
CDS headshot v2 vs v1
- ParticipantResolverv2 has also source mentioned with unknow and player.
- How is participant resolver comm. with sports API?
- GetFixtureData
- Output: get players and pass headshot for v2 data of same.
- Type v2 can be team as well,
- Participant ID in case of fixutre maps with fixtureParticipant ID
- Particpant[] id → fixtureParticipant or participantId in fixtures array
- FixtureProviderv2 calls ParticipantResolverv2
MOM:
The ParticipantResolverv2 is responsible for interacting with the Sports Radar API to retrieve and resolve participant data, which includes player information and associated headshots. The GetFixtureData method is a crucial part of this process, as it is responsible for fetching the fixture-related data, including the details of participants.
The data handled by ParticipantResolverv2 in its v2 form includes a list of players, where each player’s headshot is passed along with the v2 data. This version can represent either a team or an individual player, depending on the context of the data received.
The main concern is mapping and consistency of IDs. The Participant ID within a fixture is mapped to the fixtureParticipant ID. The ID within the Participant[] array corresponds to either the fixtureParticipant or participantId in the fixtures array, maintaining this consistency across different datasets.
The integration flow was also clarified, where FixtureProviderv2 calls ParticipantResolverv2 to obtain the necessary participant information. This information is then processed and integrated into the final output, ensuring a seamless flow of data.
As action item we need to verify the mapping of Participant[] IDs with the fixture data, ensure that headshots are correctly passed and integrated into the v2 data output, and document the interaction between ParticipantResolverv2 and FixtureProviderv2 for future reference.
Todo
TASK WHERE !completed WHERE contains(text, "#work")